Skip to content

fix: update type checks for component and module in UML drawing functions #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MaximilianSoerenPollak merged 1 commit into from
Jan 13, 2026
Merged

fix: update type checks for component and module in UML drawing functions #338

MaximilianSoerenPollak merged 1 commit into from
Jan 13, 2026

Conversation

@AlexanderLanin
Copy link
Member

@AlexanderLanin AlexanderLanin commented Jan 9, 2026

metamodel was updated, but not the draw_umml functions

Copilot AI review requested due to automatic review settings January 9, 2026 14:14
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //src:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 9b175103-0d0a-463d-8daf-9895069448fa
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //src:license-check (63 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (123 packages loaded, 2288 targets configured)

Analyzing: target //src:license-check (134 packages loaded, 2484 targets configured)

INFO: Analyzed target //src:license-check (137 packages loaded, 4500 targets configured).
[6 / 12] [Prepa] Writing repo mapping manifest for @@score_tooling+//dash/tool/formatters:dash_format_converter [for tool]
INFO: Found 1 target...
Target //src:license.check.license_check up-to-date:
  bazel-bin/src/license.check.license_check
  bazel-bin/src/license.check.license_check.jar
INFO: Elapsed time: 15.129s, Critical Path: 0.33s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/src/license.check.license_check src/formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

Copilot AI reviewed Jan 9, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates type checks in UML drawing functions to align with metamodel changes, replacing old verbose type names with shorter, simplified versions.

Key changes:

  • Type comp_arc_sta renamed to comp
  • Type mod_view_sta renamed to mod

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/extensions/score_draw_uml_funcs/helpers.py Updated component type check in safety formatting logic from comp_arc_sta to comp
src/extensions/score_draw_uml_funcs/init.py Updated type validation in module drawing function to use new type names comp and mod instead of comp_arc_sta and mod_view_sta

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

The created documentation from the pull request is available at: docu-html

@RolandJentschETAS RolandJentschETAS mentioned this pull request Jan 12, 2026
Open
2 tasks
@MaximilianSoerenPollak MaximilianSoerenPollak merged commit 30196bf into eclipse-score:main Jan 13, 2026
19 checks passed
@github-project-automation github-project-automation bot moved this from Draft to Done in Infrastructure Jan 13, 2026
RolandJentschETAS pushed a commit to etas-contrib/score_docs-as-code that referenced this pull request Jan 13, 2026
@AlexanderLanin @RolandJentschETAS
fix: update type checks for component and module in UML drawing funct…
b3443ed 
…ions (eclipse-score#338)
@RolandJentschETAS RolandJentschETAS mentioned this pull request Jan 13, 2026
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@MaximilianSoerenPollak MaximilianSoerenPollak MaximilianSoerenPollak approved these changes

@FScholPer FScholPer FScholPer approved these changes

@dcalavrezo-qorix dcalavrezo-qorix Awaiting requested review from dcalavrezo-qorix dcalavrezo-qorix is a code owner

@nradakovic nradakovic Awaiting requested review from nradakovic nradakovic is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Infrastructure
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexanderLanin @MaximilianSoerenPollak @FScholPer